Bump CRD from v1beta1 to v1 (k8s 1.16+) #2164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresmgot
approved these changes
Nov 16, 2020
antgamdia
added a commit
that referenced
this pull request
Nov 17, 2020
This reverts commit be572e8.
This was referenced Nov 17, 2020
andresmgot
pushed a commit
that referenced
this pull request
Nov 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
In k8s 1.16+ a deprecation warning of
apiextensions.k8s.io/v1beta1in favor ofapiextensions.k8s.io/v1appeared. In 1.22+ it will be fully deprecated.This PR bumps
apiextensions.k8s.io/v1beta1toapiextensions.k8s.io/v1.Benefits
Users won't get a deprecation warning. Besides, k8s 1.22+ users still will be able to install Kubeapps.
Possible drawbacks
Prior to <1.16 it won't be compatible (but these versions already reached EOL).
Applicable issues
N/A
Additional information
Perhaps it should be landed with other chart-related PRs to also bump up the chart version.