Store the last namespace used in the browser storage #2165
Conversation
dashboard/src/shared/Namespace.ts
Outdated
|
|
||
| export function setStoredNamespace(cluster: string, namespace: string) { | ||
| const ns: string = localStorage.getItem(namespaceKey) || "{}"; | ||
| const nsObject = JSON.parse(ns); |
There was a problem hiding this comment.
Shouldn't we be handling exceptions (SyntaxError) both here and 5 lines up? (just defaulting to {} if there is a syntax error, which is perhaps what you intended?)
There was a problem hiding this comment.
In theory, this info is not something the user will modify on their own so a SyntaxError won't happen but it's true that if someone tamper this data, it may cause a DoS.
I thought about this but since a session may have expired a minute ago or a month ago, there is no way of knowing that. Since there is nothing stored in the browser (and you need to re-login), and you may choose a different account, I think it's "safer" to just clean up everything (even though trying to use a namespace by default is harmless). This is to follow the same approach for all the info). |
Description of the change
Another item for #2018, store the latest namespace used in the browser so it's easier to resume previous work.
When logging out of the system (or when the session expires), this information is cleaned up.
Applicable issues