Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[jjo] use only vendor/ dependencies #25

Merged
merged 1 commit into from Nov 13, 2017
Merged

[jjo] use only vendor/ dependencies #25

merged 1 commit into from Nov 13, 2017

Conversation

jjo
Copy link
Contributor

@jjo jjo commented Nov 8, 2017 •
edited

Instrument Makefile to only use dependencies from vendor/,
(i.e. ignore local ${GOPATH}/src tree) to improve local builds
repeat-ability.

@jjo
Copy link
Contributor Author

jjo commented Nov 8, 2017

FYI relevant golang issue golang/go#19234

@ngtuna
Copy link
Contributor

ngtuna commented Nov 13, 2017

Thanks @jjo It works like a charm and we should accept this way to get rid of complex environments from users. I am landing it 🛬

@ngtuna ngtuna merged commit 1924f47 into vmware-tanzu:master Nov 13, 2017
arapulido pushed a commit to arapulido/kubeapps that referenced this pull request Feb 13, 2018
@prydonius
Merge pull request vmware-tanzu#25 from prydonius/2.0-chart-install
e56b4d9 
add ChartDeployButton component for deploying charts
@prydonius prydonius mentioned this pull request Feb 20, 2018
Closed
prydonius added a commit that referenced this pull request Feb 23, 2018
@prydonius
securely connect to mongodb service (#25)
0185f57 
fixes #60
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jjo @ngtuna