Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve release docs #2736

Merged
merged 6 commits into from
May 4, 2021
Merged

Conversation

antgamdia
Copy link
Contributor

@antgamdia antgamdia commented Apr 28, 2021

Description of the change

As I am currently releasing a new Kubeapps version, it's a good opportunity to revisit our current docs and keeping it up to date as much as possible.

Benefits

Better docs!

Possible drawbacks

N/A

Applicable issues

Additional information

Marked as draft as I am still following each section before improving it :P

@antgamdia antgamdia marked this pull request as ready for review April 30, 2021 13:35
docs/developer/release-process.md Show resolved Hide resolved
docs/developer/release-process.md Outdated Show resolved Hide resolved

## 1 - Send a PR to the bitnami/chart repository

Since the chart that we host in the Kubeapps repository is only intended for development purposes, we need to synchronize it with the official one in the [bitnami/charts repository](https://github.com/bitnami/charts/tree/master/bitnami/kubeapps). To this end, we need to send a PR with the changes to their repository and wait until it gets accepted.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that they're different repos with different directory structures, how did you create the PR (I guess if we branch the bitnami charts and copy our files over we could miss some removals etc., so did you delete all files then copy and compare?)

Copy link
Contributor Author

@antgamdia antgamdia May 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, even if there are proper ways to sync directories, I just ended up deleting and copying the files, TBH. For the automated PR, we should come up with better approaches here: git with multiple remotes (git subtree I meant), rsyncing dirs, etc


## 2 - Create a new git tag

Once the dependencies have been updated and the chart changes merged, the next step is to tagging the latest commit in master and pushing it to the main branch. Please note that the tag name will be used as the release name.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Once the dependencies have been updated and the chart changes merged, the next step is to tagging the latest commit in master and pushing it to the main branch. Please note that the tag name will be used as the release name.
Once the dependencies have been updated and the chart changes merged, the next step is to tag the latest commit in master and pushing it to the main branch. Please note that the tag name will be used as the release name.

Also, it's not necessarily the latest commit is it? If I happened to merge something while you were doing this process, you'd want to tag the specific commit that you've done some testing on no?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's true indeed! Generally, it is the latest commit, but it's better to make it explicit just in case. Thanks!


But before, we need to create and merge a PR with a chart version bump in `chart/kubeapps/Chart.yaml` ([example](https://github.com/kubeapps/kubeapps/pull/663/files)). This will trigger another CI job that will publish a new version of the chart pointing to the new Docker images built in the step 1.
You still must **add a high-level description with the release highlights**. Save the draft and **do not publish it yet**. Then, get these notes reviewed by another Kubeapps maintainer.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be worth mentioning to at least separate out all the version update commits?

@antgamdia antgamdia merged commit 141610a into vmware-tanzu:master May 4, 2021
@antgamdia antgamdia deleted the improveReleaseDocs branch May 4, 2021 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants