Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rollback test #2762

Merged
merged 3 commits into from
May 10, 2021
Merged

Add rollback test #2762

merged 3 commits into from
May 10, 2021

Conversation

antgamdia
Copy link
Contributor

Description of the change

This PR adds a new e2e test that rollbacks an application multiple times, so it tests: i) using the default value w/o interacting with the select; ii) specifying a custom value.

Benefits

This use case will be periodically tested. Hopefully, we will notice if we break these things again 馃槩

Possible drawbacks

Eventual CI errors will be more likely to happen as we increase the number of tests, but it's worthwhile :P

Applicable issues

Additional information

N/A

@antgamdia
Copy link
Contributor Author

Not passing CI as #2761 hasn't been merged yet :P

@antgamdia antgamdia mentioned this pull request May 6, 2021
10 tasks
@antgamdia
Copy link
Contributor Author

... and now it is passing :)

Copy link
Contributor

@absoludity absoludity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Why not instead update the existing 07-upgrade.js to be 07-upgrade-rollback.js, rather than having two integration tests which both perform a deploy + upgrade?

@antgamdia
Copy link
Contributor Author

Why not instead update the existing 07-upgrade.js to be 07-upgrade-rollback.js, rather than having two integration tests which both perform a deploy + upgrade?

I did consider it, but I thought it was a good idea to separate both tests as it'll be easier to know which part failed. Also, I didn't want to add much complexity to the existing test.
Also, if we don't update it, it will be semantically equivalent to the already implemented bitnami pipeline test.

That said, if you still consider it is a good idea to merge them, no strong opinion here, I'm happy to do so.

@antgamdia antgamdia merged commit cd50012 into vmware-tanzu:master May 10, 2021
@antgamdia antgamdia deleted the addRollbackTest branch May 10, 2021 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add e2e test step that rollbacks an application
2 participants