Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync chart with bitnami/kubeapps chart (version 7.0.0) #2795

Merged
merged 3 commits into from
May 14, 2021

Conversation

kubeapps-bot
Copy link
Collaborator

@kubeapps-bot kubeapps-bot commented May 12, 2021

Description of the change

This is an automatic PR for synchronizing the changes performed externally at the bitnami/kubeapps official chart to the Kubeapps development version.

Benefits

The Kubeapps development chart will get the newest changes, including image version updates and other updates.

Possible drawbacks

Although unlikely, some changes implemented by the Bitnami team may not be 100% compatible with the current Kubeapps version.

Applicable issues

N/A

Additional information

This PR is marked as a draft until a Kubeapps maintainer manually reviews it.

@antgamdia : please create a revert commit of 40bdb11 once this PR got landed.

@antgamdia
Copy link
Contributor

Woaaah it works!!! Thank you @kubeapps-bot !! 🎉

@absoludity
Copy link
Contributor

Woohoo, excellent! So regarding the CI failure:

INFO  ==> Installing latest Kubeapps chart available
INFO  ==> Installing Kubeapps...
Error from server (NotFound): secrets "localhost-tls" not found
Release "kubeapps-ci" does not exist. Installing it now.
Error: no objects visited

CircleCI received exit code 0

So it appears to be failing when trying to install the most recently released Kubeapps chart (which will be the one just released on the pipeline), before it even gets to try upgrading to the version in the branch (which should be identical, so pass). Guessing we'll need updates to installOrUpgradeKubeapps?

@antgamdia
Copy link
Contributor

Guessing we'll need updates to installOrUpgradeKubeapps?

You're right. There are two problems here:

  • Automatic upgrade is not possible since the breaking changes related to the labels.
    • Solution: hotfix ignoring the upgrade test until we merge this PR
  • The bitnami/kubeapps chart wasn't being installed (i.e., Error: no objects visited)
    • Helm 3.1. does not show validation errors, so no more information about the error was provided.
    • We just needed to add ingress.selfSigned=true as part of the flags we were already passing.

I'm gonna land a hotfix with these two changes (as they only affect the CI, which is already broken). As soon as we merge this PR, we can undo it.

See here an example of a successful CI job after the hotfix.

@antgamdia antgamdia marked this pull request as ready for review May 13, 2021 17:29
@antgamdia
Copy link
Contributor

Fix landed, green light again :) https://app.circleci.com/pipelines/github/kubeapps/kubeapps/2919/workflows/9f36715d-b010-47d4-ae7d-3e53aa805fb5

(kindly personal reminder: @antgamdia : please create a revert commit of 40bdb11 once this PR got landed)

Copy link
Contributor

@absoludity absoludity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do it :)

@absoludity absoludity merged commit d7060ec into master May 14, 2021
@absoludity absoludity deleted the sync-chart-changes-7.0.0 branch May 14, 2021 00:55
@antgamdia antgamdia mentioned this pull request May 14, 2021
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants