Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dockerfile frontend to 1.2, buildkit support graduated from experimental #2814

Merged
merged 2 commits into from
May 18, 2021

Conversation

absoludity
Copy link
Contributor

Description of the change

Noticed while adding a Dockerfile that we were still referring to the experimental (unversioned) docker frontend even though the buildkit support (for which it was added) graduated into 1.2.

Benefits

Stay on a stable API.

Possible drawbacks

Let's see what CI says.

Copy link
Contributor

@antgamdia antgamdia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting! Thanks for upgrading this!
Just a couple of doubts:

  • I guess this is for dockerfiles using a builder image. In that case, should we add the # syntax... also to the pinniped-proxy image?
  • Since it uses semver, do we really want to stick to the minor version, or should we replace it by just docker/dockerfile:1?

@absoludity
Copy link
Contributor Author

Interesting! Thanks for upgrading this!
Just a couple of doubts:

* I guess this is for dockerfiles using a builder image. In that case, should we add the `# syntax...` also to the pinniped-proxy image?

The only reason it was added for the go images was to save re-downloading all the data when building. That said, it'd be useful for the pinniped-proxy image for the same reason, for sure.

* Since it [uses semver](https://docs.docker.com/engine/reference/builder/#official-releases), do we really want to stick to the minor version, or should we replace it by just `docker/dockerfile:1`?

It explicitly needs to be >= 1.2 . As long as it'll grab the latest by default, then yep, that should be fine.

@absoludity absoludity merged commit 4e48763 into vmware-tanzu:master May 18, 2021
@absoludity
Copy link
Contributor Author

FWIW, that simplified the pinniped-proxy Dockerfile considerably, and improved the speed of the dev setup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants