Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass additional ssh key to the script. Extracted ssh values to global ci vars #2873

Merged
merged 1 commit into from
May 24, 2021

Conversation

antgamdia
Copy link
Contributor

Description of the change

This PR tries to solve a lack of permission issue since the default ssh key loaded is not valid for the forked repository.
At the same time, I've extracted the ssh-related params to CI variables, as passing manually the values is so error-prone

Benefits

Syncing charts working... hopefully

Possible drawbacks

N/A

Applicable issues

N/A

Additional information

An alternative is to define "labeled" host like:

Host github-as-kubeappsbot
  HostName github.com
  User git
  IdentityFile ~/.ssh/id_rsa.xxxxx
  IdentitiesOnly yes

But since we just need permission for pushing, it's clearer to just pass the key explicitly

@antgamdia antgamdia added this to In progress in Kubeapps via automation May 24, 2021
@antgamdia
Copy link
Contributor Author

Let me rubber-stamp this PR since it just implies changes on the CI

@antgamdia antgamdia merged commit d77d082 into vmware-tanzu:master May 24, 2021
Kubeapps automation moved this from In progress to Done May 24, 2021
@antgamdia antgamdia deleted the fixCi branch May 24, 2021 18:31
Copy link
Contributor

@absoludity absoludity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Kubeapps
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants