Sync chart with bitnami/kubeapps chart (version 7.0.3) #2874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems now the PR worflow works again! (I had to rubber-stamp #2873). |
absoludity
approved these changes
May 25, 2021
chart/kubeapps/Chart.yaml
Outdated
| @@ -25,4 +25,4 @@ maintainers: | |||
| name: kubeapps | |||
| sources: | |||
| - https://github.com/kubeapps/kubeapps | |||
| version: 7.0.2-dev1 | |||
| version: 7.0.3-dev1 | |||
There was a problem hiding this comment.
If the upstream chart is now 7.0.3, and we've just synced those changes and added our dev changes on top (great), shouldn't the version be a > 7.0.3 but < 7.0.4 ? That is, I expected version to be 7.0.4-dev1 . But if that complicates things, no problem.
There was a problem hiding this comment.
Ooops, you're totally right, my bad :P
Changing it to 7.0.4-dev1 right awway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This is an automatic PR for synchronizing the changes performed externally at the bitnami/kubeapps official chart to the Kubeapps development version.
Benefits
The Kubeapps development chart will get the newest changes, including image version updates and other updates.
Possible drawbacks
Although unlikely, some changes implemented by the Bitnami team may not be 100% compatible with the current Kubeapps version.
Applicable issues
N/A
Additional information
This PR is marked as a draft until a Kubeapps maintainer manually reviews it.