Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This PR tries to fix the current
k8s_wait_for_deployment
function behavior used in CI. When the status isTerminating
it just exits without considering the timeout. In a previous attempt, we added an additional fallback attempt, but it seems it's not enough.Example: see how it's terminating, after 10 grace seconds it tries to get the status and finally it errors (with just 2 deployments left).
Benefits
The PR #2908 will (hopefully) pass the checks again
Possible drawbacks
N/A
Applicable issues
N/A
Additional information
This approach is already being used when installing the OLM, so this change is also kind of consistent with it.