[kubeapps-apis] Add direct-helm GetAvailablePackageSummaries #3022

antgamdia · 2021-06-21T19:05:11Z

Description of the change

This PR just implements the GetAvailablePackageSummaries method in the direct-helm plugin.

AFAIK, this method just calls the assetsvc db, no Helm logic is required yet.

~~Test pending.~~

Benefits

We will have a brand new GetAvailablePackageSummaries operation up and running.

Possible drawbacks

N/A

Applicable issues

related [kubeapps-apis] Implement "direct-Helm" plugin based on the existing features in kubeapps #2993
depends on [kubeapps-apis] Add initial helm plugin generated files #3020

Additional information

~~If this approach is good, we should move some files under pkg~~ No, we shouldn't; we better expose them directly from their current package.

absoludity

Sorry, realised this is draft after first comment, so stopped :)

absoludity · 2021-06-23T03:10:47Z

chart/kubeapps/templates/kubeappsapis/deployment.yaml

+            - name: POD_NAMESPACE
+              valueFrom:
+                fieldRef:
+                  fieldPath: metadata.namespace
+            - name: ASSET_SYNCER_DB_URL
+              value: {{ template "kubeapps.postgresql.fullname" . }}-headless:{{ default "5432" .Values.postgresql.service.port }}
+            - name: ASSET_SYNCER_DB_NAME
+              value: {{ .Values.postgresql.postgresqlDatabase }}
+            - name: ASSET_SYNCER_DB_USERNAME
+              value: postgres
+            - name: ASSET_SYNCER_DB_USERPASSWORD
+              valueFrom:
+                secretKeyRef:
+                  key: postgresql-password
+                  name: {{ include "kubeapps.postgresql.secretName" . }}


We should somehow indicate that this config should be temporary only (ie. we don't want to be providing such config for plugins) until we can switch to the caching provided to plugins that will eventually come out of #2946 . You've said something similar when pulling in the utils.go temporarily below.

Conflicts: chart/kubeapps/Chart.yaml cmd/kubeapps-apis/plugins/helm/packages/v1alpha1/server.go cmd/kubeapps-apis/plugins/helm/packages/v1alpha1/server_test.go

absoludity

Great work Antonio. I think there's two things missing here:

existing checks to ensure the user has access to the namespace
correct handing of a request without the namespace

absoludity · 2021-06-24T01:00:46Z

cmd/kubeapps-apis/plugins/helm/packages/v1alpha1/server.go

+		if request.Context.Cluster != "" {
+			return nil, status.Errorf(codes.Unimplemented, "Not supported yet: request.Context.Cluster: [%v]", request.Context.Cluster)
+		}
+		if request.Context.Namespace != "" {


Not sure why this condition is required? If it is empty (""), that's the resulting value the code wants, so couldn't this condition just be removed and just include the assignment from below?

Ooops, just a leftover after copy-n-pasting from the kapp_controller plugin (there, it was initialized to namespace := globalPackagingNamespace instead of ""). Thanks for pointing this out.

Also, I'd like to re-check the `GetAvailablePackageSummariesp op in the kapp plugin, now I don't recall if we're properly using the no namespace vs "global" ns.

absoludity · 2021-06-24T01:09:00Z

cmd/kubeapps-apis/plugins/helm/packages/v1alpha1/server.go

+		}
+	}
+
+	// TODO: add more filters in the context?


Yep, FilterOptions will be part of the request message (in a later PR... I've just added this to the request message).

absoludity · 2021-06-24T01:13:29Z

cmd/kubeapps-apis/plugins/helm/packages/v1alpha1/server.go

+
+	// TODO: add more filters in the context?
+	cq := ChartQuery{
+		// TODO(agamez): verify that not including a namespace means that we return everything you can read


Correct. We can later make this more specific (I'd added an IncludeOptions message originally with options for all_namespaces and global_items, but Dimitri doesn't think it's needed, so we agreed on the above: if a namespace is not included, then the request is for all available packages to which you have access (encapsulating both across all namespaces and global ones). It means there's (currently) know way to request just global available packages, but easy to add in if we find we do need it.

So currently, if namespace is empty, we're going to need to determine the list of namespaces to which the user has access, then query for the charts in those namespaces together with the kubeapps (global) namespace?

absoludity · 2021-06-24T01:14:26Z

cmd/kubeapps-apis/plugins/helm/packages/v1alpha1/server.go

+		namespace: namespace,
+	}
+
+	// We are not returning paginated results here


Suggested change

// We are not returning paginated results here

// TODO: We are not yet returning paginated results here.

?

absoludity · 2021-06-24T01:21:22Z

cmd/kubeapps-apis/plugins/helm/packages/v1alpha1/server_test.go

+			manager:      manager,
+			clientGetter: getter,
+		},
+	}


Nice clear tests :)

absoludity · 2021-06-24T01:53:56Z

cmd/kubeapps-apis/plugins/helm/packages/v1alpha1/server.go

+		if request.Context.Namespace != "" {
+			namespace = request.Context.Namespace
+		}
+	}


At this point, I think we need to be checking the users credentials? That is, if a namespace is set, we need to ensure the user has access to that namespace (the existing code checks if the user can read secrets in the namespace). The existing code does this check as a decorator function in AuthGate that wraps the handlers.

If namespace is empty, then we'll need to know the namespaces to which the user has access, I think (diverging from the current assetsvc implementation, which assumes empty means global repos).

Great, good point here. Thanks for pointing to the auth code (I will comment on my code about it). I've added a check that will prevent users from retrieving packages from ns they can't read.
As you mentioned later, the ns=="" case won't be implemented yet.

absoludity · 2021-06-24T02:04:59Z

cmd/kubeapps-apis/plugins/helm/packages/v1alpha1/server_test.go

+}
+
+func TestGetAvailablePackageSummaries(t *testing.T) {
+	getter := func(context.Context) (dynamic.Interface, error) {


Not sure the k8s client is used currently, but it will be when we add a test ensuring that it 403s for namespaces to which the user doesn't have access, etc.

absoludity · 2021-06-24T02:11:13Z

cmd/kubeapps-apis/plugins/helm/packages/v1alpha1/server_test.go

+			mock.ExpectQuery("^SELECT count(.+) FROM").
+				WillReturnRows(rowCount)
+
+			availablePackageSummaries, err := s.GetAvailablePackageSummaries(context.Background(), &corev1.GetAvailablePackageSummariesRequest{Context: &corev1.Context{}})


Currently this is just testing only one case where the namespace is empty? We'd want to ensure that we test the cases:

specific namespace results a 403 if the user doesn't have access to the ns

specific namespace results in a query for charts in that ns only otherwise,

blank namespace results in a query for charts in the kubeapps namespace and any namespace to which the user has access

I think?

absoludity · 2021-06-24T02:33:31Z

cmd/kubeapps-apis/plugins/helm/packages/v1alpha1/utils.go

+// TODO(agamez): logic temporaryly extracted from:
+// /cmd/assetsvc/postgresql_utils.go
+// /cmd/assetsvc/utils.go
+// we can either: export this logic under pkg or re-implement the data access layer with an ORM


Why not ensure this functionality is exported in its current location? If that's an issue, keen to know why. If it's not an issue, I'd recommend just doing it as a separate, pre-quel branch, that is:

Public interface assetManager -> AssetManager

Public NewPGManager

Public methods

In fact, let me see if I can do that for you to save you the time: #3036 (if you agree, just land that and update).

Thank you for performing that changes. I initially opted to copy-n-paste the required logic just to have a clear idea of what was really necessary and what's not.
Also, I didn't want to mix things up, so I just thought, ok let's do it in another PR, but I didn't manage to do it yet, haha.

However, after yours, I've created this another PR #3040. More details there, but I had to move the files to a different folder and go package so that I was able to import them. Perhaps I'm missing something.

absoludity · 2021-06-24T06:51:14Z

Great work Antonio. I think there's two things missing here:
* existing checks to ensure the user has access to the namespace

* correct handing of a request without the namespace

Actually, thinking more about the last point, perhaps it's enough to just return Unimplemented for now for GetAvailablePackageSummaries without a namespace, given that the current UI doesn't even do this (it was part of ensuring a future possibility with a different workflow). Thoughts?

…ePackageSummaries

…onse

antgamdia · 2021-06-25T00:57:10Z

Actually, thinking more about the last point, perhaps it's enough to just return Unimplemented for now for GetAvailablePackageSummaries without a namespace, given that the current UI doesn't even do this (it was part of ensuring a future possibility with a different workflow). Thoughts?

That's what I was about to say: let's replicate the current behavior as much as possible, so that we speed up the dev process. Later on, we can start thinking about implementing the TODOs.
I've pushed an initial version of the ns check using the existing logic for the can-i method.

Problem: the client we are passing back to the plugins (via clientGetter) is just for dynamic interfaces, That is, we can't query structured/typed data like a selfsubjectaccessreviews.
Here I've just implemented a temporary workaround, but, my question is: should we also pass to the plugin a normal k8s client besides the existing one?

btw: tests are still pending (I'll do it tomorrow)

antgamdia · 2021-06-25T01:01:33Z

cmd/kubeapps-apis/plugins/helm/packages/v1alpha1/server.go

+	unstructuredData, err := runtime.DefaultUnstructuredConverter.ToUnstructured(&authorizationapi.SelfSubjectAccessReview{
+		Spec: authorizationapi.SelfSubjectAccessReviewSpec{
+			ResourceAttributes: &authorizationapi.ResourceAttributes{
+				Group:     "",
+				Resource:  "secrets",
+				Verb:      "get",
+				Namespace: namespace,
+			},
+		},
+	})
+	if err != nil {
+		return false, fmt.Errorf("Error parsing the selfSubjectAccessReviews request: %s", err)
+	}
+	selfSubjectAccessReviewsResponse, err := client.Resource(selfSubjectAccessReviews).Create(ctx, &unstructured.Unstructured{Object: unstructuredData}, metav1.CreateOptions{})
+	if err != nil {
+		return false, fmt.Errorf("Error creating the selfSubjectAccessReviews request: %s", err)
+	}
+	res := &authorizationapi.SelfSubjectAccessReview{}
+	err = runtime.DefaultUnstructuredConverter.FromUnstructured(selfSubjectAccessReviewsResponse.Object, res)


This is what I meant by temporary ugly workaround :P . I just needed to use the dynamic client, so I converted it with ToUnstructured and with FromUnstructured

Yep, see #3043 .

antgamdia · 2021-06-25T01:04:37Z

cmd/kubeapps-apis/proto/kubeappsapis/core/packages/v1alpha1/packages.proto

@@ -70,12 +70,21 @@ message GetAvailablePackageSummariesRequest {
  // The context (cluster/namespace) for the request
  Context context = 1;

+  // FilterOptions
+  //
  // FilterOptions available when requesting summaries
  message FilterOptions {


Adding these comments for a better swagger document.
When embedding these messages inside other msgs we often forgot to add the proper docs, that's why I tend not to embed them. But, on the other side, it's clearer to know which mgs they belong to, so... no strong opinion though.

Yep, and better to have those comments already if we later then move the embedded message out to re-use it. But again, if it's OK with you, I'll add those in the separate PR which hasn't landed yet which adds the filter options. It'll be easier if you don't merge that here nor add functionality depending on them in this PR, but rather keep this one focused on getting the available package summaries (securely, checking the namespace) without filter options. Just so we can work together without depending on unlanded branches.

Or if you want to update once it's landed and still include the filters, that's fine too, but just keen to avoid depending on other people's unlanded code unless it's necessary (ie. if this PR was dependent on filtering options, but I don't think it is).

Hah - so I just found the source of confusion here. Sorry, it was my fault. I'd thought I'd created a PR with the filter options yesterday... but it turns out I'd created the branch before our standup but didn't get back to push it and create the PR. I only found out because I just went to update my branch and pushed the changes to find that it created a new branch on GH. So from your POV you obviously weren't working on something that I'd done at all. Sorry for the confusion :)

Hahah, I wasn't getting the point here; I added the FilterOptions in my branch so, as you said, I didn't see you were also working on that. It totally makes sense now.
I'll add the remaining changes to the filter (version and app version) here so that we have the whole filtering functionality implemented.

absoludity

I've pushed an initial version of the ns check using the existing logic for the can-i method.

Problem: the client we are passing back to the plugins (via clientGetter) is just for dynamic interfaces, That is, we can't query structured/typed data like a selfsubjectaccessreviews.
Here I've just implemented a temporary workaround, but, my question is: should we also pass to the plugin a normal k8s client besides the existing one?

Yep. I've jumped in to do that separately for you in #3043 .

btw: tests are still pending (I'll do it tomorrow)

Yep, let me know when it's ready and I'll finish the review. Thanks!

absoludity · 2021-06-25T01:57:36Z

cmd/kubeapps-apis/plugins/helm/packages/v1alpha1/server.go

@@ -56,3 +85,160 @@ func (s *Server) GetClient(ctx context.Context) (dynamic.Interface, error) {
 	}
 	return client, nil
 }
+
+// GetManager ensures a manager is available and uses it to return the client.


Suggested change

// GetManager ensures a manager is available and uses it to return the client.

// GetManager ensures a manager is available and returns it.

absoludity · 2021-06-25T01:59:22Z

cmd/kubeapps-apis/plugins/helm/packages/v1alpha1/server.go

+	// otherwise, first check if the user can access the requested ns
+	if namespace == "" {
+		// TODO(agamez): not including a namespace means that it returns everything a user can read
+		return nil, status.Errorf(codes.Unimplemented, "Not supported yet: not including a namespace means that it returns everything a user can read")


absoludity · 2021-06-25T02:00:21Z

cmd/kubeapps-apis/plugins/helm/packages/v1alpha1/server.go

+	if namespace == "" {
+		// TODO(agamez): not including a namespace means that it returns everything a user can read
+		return nil, status.Errorf(codes.Unimplemented, "Not supported yet: not including a namespace means that it returns everything a user can read")
+	} else {


Generally avoid an unnecessary else and it's required indentation etc. (since the actual condition above returns, exiting the fn).

I do agree (I'll change it). However, I decided to leave the else statement since, at some point, the if branch will have some logic. This way, fewer git changes (aka indentation) when we add the "no namespace" case.
Anyway, happy to remove it.

Yep, up to you (I don't mind, just a general note for clarity).

absoludity · 2021-06-25T02:07:36Z

cmd/kubeapps-apis/plugins/helm/packages/v1alpha1/server.go

+
+	// TODO(agamez): this is a temporary workaround since the client getter we (the plugin) get is just
+	// for dynamic interfaces. I guess we should also pass a normal k8s client in case the plugins want to
+	// interact with typed kubernetes resources.


Yes, that's a good point. We started with the dynamic client because otherwise we're dependent on the client-go version of 3rd party CRDs for packaging related queries. But for standard k8s resources it would be nice to have the typed client too.

Did this in #3043 . Feel free to land that and update, or just review it and continue your PR without it (and I'll update later).

absoludity · 2021-06-25T05:19:13Z

cmd/kubeapps-apis/plugins/helm/packages/v1alpha1/server.go

+	unstructuredData, err := runtime.DefaultUnstructuredConverter.ToUnstructured(&authorizationapi.SelfSubjectAccessReview{
+		Spec: authorizationapi.SelfSubjectAccessReviewSpec{
+			ResourceAttributes: &authorizationapi.ResourceAttributes{
+				Group:     "",
+				Resource:  "secrets",
+				Verb:      "get",
+				Namespace: namespace,
+			},
+		},
+	})
+	if err != nil {
+		return false, fmt.Errorf("Error parsing the selfSubjectAccessReviews request: %s", err)
+	}
+	selfSubjectAccessReviewsResponse, err := client.Resource(selfSubjectAccessReviews).Create(ctx, &unstructured.Unstructured{Object: unstructuredData}, metav1.CreateOptions{})
+	if err != nil {
+		return false, fmt.Errorf("Error creating the selfSubjectAccessReviews request: %s", err)
+	}
+	res := &authorizationapi.SelfSubjectAccessReview{}
+	err = runtime.DefaultUnstructuredConverter.FromUnstructured(selfSubjectAccessReviewsResponse.Object, res)


Yep, see #3043 .

Conflicts: cmd/assetsvc/handler.go cmd/assetsvc/handler_test.go cmd/assetsvc/main.go cmd/assetsvc/pkg/assetsvc_utils/postgresql_utils.go cmd/assetsvc/pkg/assetsvc_utils/postgresql_utils_test.go cmd/assetsvc/pkg/assetsvc_utils/utils.go cmd/assetsvc/pkg/utils/postgresql_utils.go cmd/assetsvc/pkg/utils/postgresql_utils_test.go cmd/assetsvc/pkg/utils/utils.go cmd/assetsvc/postgres_db_test.go cmd/assetsvc/postgresql_utils.go cmd/assetsvc/postgresql_utils_test.go cmd/assetsvc/utils.go cmd/kubeapps-apis/gen/core/packages/v1alpha1/packages.pb.go cmd/kubeapps-apis/plugins/helm/packages/v1alpha1/server.go

absoludity

Great, +1. Thanks Antonio. Is it worth implementing the pagination support in the request for this now? What else is required for this method to be used in the client?

absoludity · 2021-06-29T01:22:47Z

cmd/kubeapps-apis/plugins/helm/packages/v1alpha1/server_test.go

+			expectedPackages: []*corev1.AvailablePackageSummary{},
+			statusCode:       codes.Unauthenticated,
+		},
+	}


Excellent :)

absoludity · 2021-06-29T01:25:21Z

cmd/kubeapps-apis/plugins/helm/packages/v1alpha1/server.go

+				Namespace: namespace,
+			},
+		},
+	}, metav1.CreateOptions{})


Much neater.

absoludity · 2021-06-29T06:44:40Z

cmd/kubeapps-apis/proto/kubeappsapis/core/packages/v1alpha1/packages.proto

+    // Package version
+    //
+    // Package version for the request
+    string version = 4;


I think elsewhere we've stared using pkg_version to be specific together with app_version as you've used below?

Good idea indeed. I've added some comments in the doc for unifying the names here. Using just version could be misleading in some cases. I'd change each version by either pkg_ or app_ prefixes.

antgamdia · 2021-06-29T16:15:57Z

Is it worth implementing the pagination support in the request for this now? What else is required for this method to be used in the client?

Additional fields for this method

Currently, the client requires the following params for displaying the catalog: icon, name, repo, version, description, namespace, id

A typical response of the new API is something like this:

{
  "availablePackagesSummaries": [
    {
      "availablePackageRef": {
        "context": {
          "namespace": "kubeapps" namespace
        },
        "identifier": "marketplace/airflow" id
      },
      "latestVersion": "10.2.1", version
      "iconUrl": "https://bitnami.com/assets/stacks/airflow/img/airflow-stack-220x234.png", icon
      "displayName": "airflow", name
      "shortDescription": "Apache Airflow is a platform to programmatically author, schedule and monitor workflows." description
    }
  ]
};

So the only missing field is repo (it could eventually be retrieved using the identifier).

Pagination

Well, this is interesting. Currently, the API is returning something like:

{"data":[ charts ],"meta":{"totalPages": pages }}

Perhaps, we could modify the messages to use this data/meta approach. Or even go with some of these options:

GitHub is using the Links header: https://docs.github.com/en/rest/guides/traversing-with-pagination
Google suggests including the pagination as part of the proto msg: https://cloud.google.com/apis/design/design_patterns#list_pagination

However, I'd rather land this PR, continue to work on the other operation and, later on, look into these two additional things in a separate PR. Specially pagination... we should come to an agreement before start changing the UI.
(I'm gonna crosspost it in the parent issue)

absoludity · 2021-06-30T03:52:19Z

However, I'd rather land this PR, continue to work on the other operation and, later on, look into these two additional things in a separate PR. Specially pagination... we should come to an agreement before start changing the UI.

Great, yes - I didn't mean to imply it should be in this PR, just trying to ensure we work on the most relevant things next.

(I'm gonna crosspost it in the parent issue)

Great, I'll reply there :)

antgamdia added 6 commits June 21, 2021 13:27

Add initial helm plugin gen files

e7f36f5

Minor indentation fix

9b19630

Add initial GetAvailablePackageSummaries

05cd160

Add env vars in the chart

31d8cf2

Fix bad indentation

e5531f8

Change log dep

f6ef89d

antgamdia changed the title ~~[kubeappaps-apis] Add direct-helm GetAvailablePackageSummaries~~ [kubeapps-apis] Add direct-helm GetAvailablePackageSummaries Jun 22, 2021

antgamdia mentioned this pull request Jun 22, 2021

[kubeapps-apis] Implement "direct-Helm" plugin based on the existing features in kubeapps #2993

Closed

9 tasks

Add helm plugin to dockerfile

3be471b

absoludity reviewed Jun 23, 2021

View reviewed changes

antgamdia added 7 commits June 23, 2021 11:37

Merge branch 'master'

0229bcf

Conflicts: chart/kubeapps/Chart.yaml cmd/kubeapps-apis/plugins/helm/packages/v1alpha1/server.go cmd/kubeapps-apis/plugins/helm/packages/v1alpha1/server_test.go

Add comment in deploy

73c52a3

Add TestGetClient

c40f9f4

Add TestAvailablePackageSummaryFromChart

40c84ab

Add TestGetAvailablePackageSummaries

7685928

Minor fix handling an error

c8b81ba

Add todo

9568eb1

antgamdia marked this pull request as ready for review June 23, 2021 20:13

antgamdia mentioned this pull request Jun 23, 2021

[kubeapps-apis] Add direct-helm GetAvailablePackageDetail #3034

Merged

absoludity mentioned this pull request Jun 24, 2021

Update the postgresql asset manager to be publicly exported. #3036

Merged

absoludity reviewed Jun 24, 2021

View reviewed changes

antgamdia added 8 commits June 24, 2021 15:49

Merge branch 'master' into 2993-helmPlugin-GetAvailablePackageSummaries

b6fbd93

Extract assetsvc shared logic to pkg assetsvc_utils

c3df1e1

Merge branch 'extractAssetsvcShared' into 2993-helmPlugin-GetAvailabl…

6e1908a

…ePackageSummaries

Remove temporary utils. Use assetsvc_utils instead

1847768

Remove unnecesary ns check

3ef34e2

Add descriptions to the FilterOptions proto msg

03455f0

Use FilterOptions in GetAvailablePackageSummaries

cd52299

Make repositories in FilterOptions repeated

551b0ec

Check if users has access to a namespace prior to generating the resp…

d729040

…onse

antgamdia commented Jun 25, 2021

View reviewed changes

absoludity mentioned this pull request Jun 25, 2021

Add typed client to plugin client getter. #3043

Merged

absoludity reviewed Jun 25, 2021

View reviewed changes

antgamdia added 10 commits June 25, 2021 10:05

Add remaining changes for the typed client

2c56081

Add extra fields in FilterOptions

609eea4

Use the appVersion and version in the operation

f7aa571

Extract filterOptions msg for testing

b193948

Add test checking if user has access to the ns

e963a0c

Add test checking if user has access to the ns

275c56e

Add test for querying specifc ns

6992414

Merge

9dd50ca

Minor fixes

d278b12

antgamdia force-pushed the 2993-helmPlugin-GetAvailablePackageSummaries branch from 4582e07 to d278b12 Compare June 25, 2021 14:52

Trigger build

789f70c

absoludity approved these changes Jun 29, 2021

View reviewed changes

absoludity reviewed Jun 29, 2021

View reviewed changes

antgamdia added 2 commits June 29, 2021 16:00

Merge branch 'master' into 2993-helmPlugin-GetAvailablePackageSummaries

80d496b

Rename version with pkg_version

be680b5

antgamdia merged commit 2d404ee into vmware-tanzu:master Jun 29, 2021

antgamdia deleted the 2993-helmPlugin-GetAvailablePackageSummaries branch June 29, 2021 16:20

	// We are not returning paginated results here
	// TODO: We are not yet returning paginated results here.

	// GetManager ensures a manager is available and uses it to return the client.
	// GetManager ensures a manager is available and returns it.

[kubeapps-apis] Add direct-helm GetAvailablePackageSummaries #3022

[kubeapps-apis] Add direct-helm GetAvailablePackageSummaries #3022

Conversation

antgamdia commented Jun 21, 2021 • edited

Description of the change

Benefits

Possible drawbacks

Applicable issues

Additional information

absoludity left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

absoludity left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

antgamdia Jun 24, 2021 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

absoludity commented Jun 24, 2021

antgamdia commented Jun 25, 2021 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

absoludity Jun 25, 2021 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

absoludity left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

absoludity left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

antgamdia commented Jun 29, 2021 • edited

Additional fields for this method

Pagination

absoludity commented Jun 30, 2021

antgamdia commented Jun 21, 2021 •

edited

antgamdia Jun 24, 2021 •

edited

antgamdia commented Jun 25, 2021 •

edited

absoludity Jun 25, 2021 •

edited

antgamdia commented Jun 29, 2021 •

edited