Misc todo cleanup in fluxv2 plugin #3030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absoludity
approved these changes
Jun 23, 2021
| } | ||
| repo.Namespace = namespace | ||
|
|
||
| repoPackages, err := readPackagesFromRepoIndex(&repo, url) |
There was a problem hiding this comment.
Probably worth a TODO at the start of the surrounding iteration that each repo should be read in a separate go routine, if this code is used in the future.
pkg/http-client/httpclient.go
Outdated
| ) | ||
|
|
||
| type Client interface { | ||
| Do(req *http.Request) (*http.Response, error) | ||
| } | ||
|
|
||
| // | ||
| // creates a new instance of Client, given a path to addtional certificates | ||
| // certFile may be empty string, which means no additional certs will be used |
There was a problem hiding this comment.
I think this copy-n-paste needs updating :)
pkg/http-client/httpclient.go
Outdated
| // | ||
| // creates a new instance of Client, given a path to addtional certificates | ||
| // certFile may be empty string, which means no additional certs will be used | ||
| // |
There was a problem hiding this comment.
Just note that generally golang docstrings are not preceded with an empty //\n line (nor followed by one), and usually begin with the function/struct/constant name, such as:
// Foo does stuff before returning nil
// Extra details about Foo here.
func Foo() nil
See https://blog.golang.org/godoc for the background, but it just plays well with the godoc binary.
There was a problem hiding this comment.
mmm, maybe, but it makes code easier to read. Oh well, when in Rome 👍 I will change it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to clean up and merge some todo items leftover from the previous PR before I embark on a new big task to add caching layer to fluxv2 plug-in