Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run misspell to auto-fix typos #3312

Merged
merged 2 commits into from
Aug 27, 2021
Merged

Conversation

antgamdia
Copy link
Contributor

Description of the change

I just found https://github.com/client9/misspell and it seemed interesting running it, so I did.

Benefits

Fewer typos in our codebase

Possible drawbacks

N/A

Applicable issues

N/A

Additional information

N/A

Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Copy link
Contributor

@absoludity absoludity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. We might want that in the image build so we don't allow new typos/spellos in.

Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>

Conflicts:
	docs/developer/manifests/values.kubeappsapis.yaml
@antgamdia antgamdia merged commit 9df7576 into vmware-tanzu:master Aug 27, 2021
@antgamdia antgamdia deleted the misspell branch August 27, 2021 13:37
@antgamdia
Copy link
Contributor Author

Great. We might want that in the image build so we don't allow new typos/spellos in.

Yes, I thought of it, but I just check every root folder manually, we have to come up with the proper command args to prevent this tool from fixing false positives. That's why I didn't add this as part of the current listing stage right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants