Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update integration image #3878

Merged
merged 3 commits into from
Dec 1, 2021
Merged

Update integration image #3878

merged 3 commits into from
Dec 1, 2021

Conversation

antgamdia
Copy link
Contributor

Description of the change

As part of the release process, we ought to update the integration image with the latest changes (just bumping up deps), so this PR is to perform this change.
I've pushed upstream so that the CI gets the changes.

Benefits

Perhaps new versions bring more CI stability?

Possible drawbacks

Perhaps new versions bring more CI instability?

Applicable issues

N/A

Additional information

N/A

Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
@@ -1,5 +1,6 @@
{
"name": "dashboard",
"proxy": "https://localhost",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for my understanding, what is the purpose of adding the proxy here? I don't mean technically, but more the reasoning behind. Thanks! 😄

Copy link
Contributor Author

@antgamdia antgamdia Dec 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hahaha, it is just me clicking the wrong "commit all" button instead of "commit staged" one 🤦 Thanks for pointing this out.
The main purpose is for setting my local development environment up, so that I can work on the dashboard.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!
If it helps, in order to avoid having to modify the package.json for this purpose, I add in my local a src/setupProxy.js file like this

const createProxyMiddleware = require('http-proxy-middleware');

module.exports = function(app) {
  app.use(
    ['/apis', '/api'],
    createProxyMiddleware({
      target: 'http://localhost',
      changeOrigin: true,
    })
  );
};

It is also a file that could be committed by mistake, but maybe we could add it to .gitignore 😅

Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
@antgamdia antgamdia merged commit 22a2f3f into master Dec 1, 2021
@antgamdia antgamdia deleted the updateIntegrationImg branch December 1, 2021 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants