Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync chart with bitnami/kubeapps chart (version 7.6.1) #3882

Merged
merged 3 commits into from
Dec 2, 2021

Conversation

kubeapps-bot
Copy link
Collaborator

Description of the change

This is an automatic PR for synchronizing the changes performed externally at the bitnami/kubeapps official chart to the Kubeapps development version.

Benefits

The Kubeapps development chart will get the newest changes, including image version updates and other updates.

Possible drawbacks

Although unlikely, some changes implemented by the Bitnami team may not be 100% compatible with the current Kubeapps version.

Applicable issues

N/A

Additional information

This PR is marked as a draft until a Kubeapps maintainer manually reviews it.

kubeapps-bot and others added 2 commits December 1, 2021 21:08
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
@antgamdia antgamdia marked this pull request as ready for review December 1, 2021 22:02
@@ -33,4 +33,4 @@ maintainers:
name: kubeapps
sources:
- https://github.com/kubeapps/kubeapps
version: 7.6.0
version: 7.6.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a big deal, but shouldn't this be 7.6.1-dev0 so that it's ahead of the released 7.6.1 chart but before any release 7.6.2 chart? Fine as is, just remembering our previous conv about it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, that's true... since there are no actual changes in the chart (apart from the container versions), I forgot to update it. In fact, I'd say it should be v7.6.2-dev0, because the -foo suffix is for prereleases (semver compare v7.6.1-dev0 v7.6.1 yields -1

Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
@antgamdia antgamdia merged commit 72e1d7a into master Dec 2, 2021
@antgamdia antgamdia deleted the sync-chart-changes-7.6.1 branch December 2, 2021 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants