Fix install repo firing twice (#3678) #3891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 2, 2021 13:05
Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
antgamdia
approved these changes
Dec 3, 2021
| @@ -620,7 +627,7 @@ export function AppRepoForm(props: IAppRepoFormProps) { | |||
| </Alert> | |||
| )} | |||
| <div className="margin-t-xl"> | |||
| <CdsButton disabled={validating} onClick={install}> | |||
| <CdsButton type="submit" disabled={validating}> | |||
There was a problem hiding this comment.
Why are you removing the onClick event? Perhaps this same function is also being triggered in the onSubmit?
There was a problem hiding this comment.
U nailed it! install function was being called twice: here and inside form's onSubmit logic.
| @@ -49,6 +49,7 @@ const TYPE_OCI = "oci"; | |||
|
|
|||
| export function AppRepoForm(props: IAppRepoFormProps) { | |||
| const { onSubmit, onAfterInstall, namespace, kubeappsNamespace, repo, secret } = props; | |||
| const workingRef = useRef(false); | |||
There was a problem hiding this comment.
I'd maybe choose another name, a more self-explanatory one like isInstallingRef ?
There was a problem hiding this comment.
You are right, will rename it. Initially I wanted to make the solution something general for all forms+buttons :)
Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Rafa Castelblanque rcastelblanq@vmware.com
Description of the change
Fixes the problem of "Install Repo" button being fired multiple times.
Benefits
Repo installation process is not triggered more than once.
Possible drawbacks
N/A
Applicable issues
Additional information
Makes use of React's useRef