Sync chart with bitnami/kubeapps chart (version 7.6.2) #3893
Conversation
chart/kubeapps/values.yaml
Outdated
| @@ -1515,7 +1515,7 @@ clusters: | |||
| domain: cluster.local | |||
| ## @param featureFlags [object] Feature flags (used to switch on development features) | |||
| ## | |||
| featureFlags: | |||
| featureFlags: "" | |||
There was a problem hiding this comment.
This should be {}, but the Bitnami team is already aware and they're gonna fix it in a separate upstream PR
There was a problem hiding this comment.
Well, they didn't perform the change (probably they're on PTO), so let me squeeze the change in our dev chart so that it gets synced with the upstream one at some point.
chart/kubeapps/Chart.yaml
Outdated
| @@ -33,4 +33,4 @@ maintainers: | |||
| name: kubeapps | |||
| sources: | |||
| - https://github.com/kubeapps/kubeapps | |||
| version: 7.6.2-dev0 | |||
| version: 7.6.2 | |||
There was a problem hiding this comment.
Ah, guess since we're not changing anything, 7.6.2 is what it is synced as... our first change in dev will make it 7.6.3-dev0 - sorry for the noise :)
There was a problem hiding this comment.
It depends... it's fine either way. Our chart will always differ from the bitnami one in the images. If we consider it is a change that leads to a vX.Y.Z+1-dev0 it's ok. I'm also comfortable with leaving it as is (vX.Y.Z).
I'm guessing this PR was automatically created as draft and meant to mark it as ready for review? Anyway, +1
They released this new version as part of a batch PR for solving an issue with their readmenator. However, they made some mistakes in the default value (using "" instead of {}), but they will solve it soon. I didn't perform any changes to this PR as I was waiting for them to send the new one. That's why it is still a draft (this is how the bot creates the PRs).
So, my plan is to leave it open (because otherwise, the bot would create another one again and again) until they fix it, then close this one and perform the changes in the new PR.
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> Conflicts: chart/kubeapps/Chart.yaml
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
| ## Proxy configuration to access chart repositories | ||
| ## | ||
| ## @param apprepository.initialReposProxy.enabled Enables the proxy | ||
| ## @param apprepository.initialReposProxy.httpProxy URL for the http proxy | ||
| ## @param apprepository.initialReposProxy.httpsProxy URL for the https proxy | ||
| ## @param apprepository.initialReposProxy.noProxy URL to exclude from using the proxy |
There was a problem hiding this comment.
Adding this new change to remove the [object] modifier in as many places as possible.
Description of the change
This is an automatic PR for synchronizing the changes performed externally at the bitnami/kubeapps official chart to the Kubeapps development version.
Benefits
The Kubeapps development chart will get the newest changes, including image version updates and other updates.
Possible drawbacks
Although unlikely, some changes implemented by the Bitnami team may not be 100% compatible with the current Kubeapps version.
Applicable issues
N/A
Additional information
This PR is marked as a draft until a Kubeapps maintainer manually reviews it.