Only watch resources that are updated in UX. #3902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Nelson <minelson@vmware.com>
Signed-off-by: Michael Nelson <minelson@vmware.com>
Signed-off-by: Michael Nelson <minelson@vmware.com>
absoludity
commented
Dec 6, 2021
| @@ -39,7 +39,7 @@ export const requestResources = createAction("REQUEST_RESOURCES", resolve => { | |||
| watch: boolean, | |||
| handler: (r: GetResourcesResponse) => void, | |||
| onError: (e: Event) => void, | |||
| onComplete: (pkg: InstalledPackageReference) => void, | |||
| onComplete: () => void, | |||
There was a problem hiding this comment.
There was no need for the arg since it can be included via closure.
| return () => {}; | ||
| } | ||
|
|
||
| const parsedRefs = parseResources(app.apiResourceRefs); | ||
| setAppViewResourceRefs(parsedRefs); | ||
| return () => {}; | ||
| }, [app, cluster, kinds, appViewResourceRefs]); | ||
| }, [app?.apiResourceRefs]); |
There was a problem hiding this comment.
Just cleaned up the dependencies (ie. we don't want to fire this effect whenever the app changes, only when the resource refs change).
|
Awesome! From 40 to 13 watches :) |
castelblanque
approved these changes
Dec 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Michael Nelson minelson@vmware.com
Description of the change
Rather than watching all resources for an installed package (as Kubeapps has done for quite some time), this PR updates so that we only watch the resources which are updated in the UX and just fetch the rest once only when the AppView is mounted.
Benefits
Viewing Kubeapps, for example, now results in only 13 watches on the k8s API server (from the plugin), rather than ~40.
Possible drawbacks
Applicable issues
Additional information