Add implementation for Namespace related GRPC methods in resources plugin #3910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -416,13 +416,16 @@ func resourceRefsEqual(r1, r2 *pkgsGRPCv1alpha1.ResourceRef) bool { | |||
|
|
|||
| // errorByStatus generates a meaningful error message | |||
| func errorByStatus(verb, resource, identifier string, err error) error { | |||
| // If the error is already a k8s StatusError, return the StatusErr | |||
There was a problem hiding this comment.
@absoludity Is this a TO-DO comment?
There was a problem hiding this comment.
Yes - it was a note to myself but something I didn't end up doing. Removed, thanks!
absoludity
force-pushed
the
3896-namespaces-via-plugin
branch
from
c706682
to
ee2f1a3
Compare
plugin. Signed-off-by: Michael Nelson <minelson@vmware.com>
Signed-off-by: Michael Nelson <minelson@vmware.com>
absoludity
force-pushed
the
3896-namespaces-via-plugin-2
branch
from
b19eb6e
to
8a8547d
Compare
castelblanque
approved these changes
Dec 10, 2021
antgamdia
reviewed
Dec 13, 2021
Comment on lines
+425
to
+427
| return status.Errorf(codes.PermissionDenied, "Unauthorized to %s the %s '%s' due to '%v'", verb, resource, identifier, err) | ||
| } else if errors.IsAlreadyExists(err) { | ||
| return status.Errorf(codes.AlreadyExists, "Cannot %s the %s '%s' due to '%v' as it already exists", verb, resource, identifier, err) |
There was a problem hiding this comment.
I'll probably want to cherry-pick this change for the kapp plugin, as I'm using a similar function.
Long-term, perhaps we could extract these util functions to a separate pkg that others can import.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Michael Nelson minelson@vmware.com
Description of the change
Follows on from #3905 , adding the implementation of those namespace GRPC methods of the resource plugin.
Benefits
The next PR will be for the dashboard and can remove the calls to the K8s API server for the namespace functionality.
Possible drawbacks
Applicable issues
Additional information