Switch dashboard to use checkNamespaceExists. #3911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+22
to
+25
| await this.resourcesClient().CreateNamespace({ | ||
| context: { | ||
| cluster, | ||
| namespace, |
There was a problem hiding this comment.
It looks cleaner than before :)
|
One more step to abstract away from direct K8s API calls. Thanks! |
castelblanque
approved these changes
Dec 9, 2021
plugin. Signed-off-by: Michael Nelson <minelson@vmware.com>
Signed-off-by: Michael Nelson <minelson@vmware.com>
absoludity
force-pushed
the
3896-namespaces-via-plugin-2
branch
from
b19eb6e
to
8a8547d
Compare
Signed-off-by: Michael Nelson <minelson@vmware.com>
Signed-off-by: Michael Nelson <minelson@vmware.com>
absoludity
force-pushed
the
3896-namespaces-via-plugin-3
branch
from
ca92864
to
f12f974
Compare
Thanks for the approval. Just note that I can't land this as the previous PR isn't yet approved. If it's easier, you can see the whole series of PRs for this work on #3896 |
castelblanque
approved these changes
Dec 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Michael Nelson minelson@vmware.com
Description of the change
Updates the dashboard to use the resources plugin to check if a namespace exists (rather than the more generic getNamespace which was hitting the k8s API server directly from the dashboard).
Also updates the
Namespace.createshared helper to use the resources client.Benefits
See #3896
Possible drawbacks
Applicable issues
Additional information