-
Notifications
You must be signed in to change notification settings - Fork 702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add implementation for resources secret endpoints #3915
Conversation
Great, now Kubeapps is not exposing secret contents anymore, and we are moving away from k8s API server calls. |
Not for the dashboard endpoints that will switch to use this API. Note that the
Yay to that :) |
bc5ea31
to
848138a
Compare
be5935e
to
f201bff
Compare
848138a
to
12cf536
Compare
f201bff
to
7ebab5f
Compare
7ebab5f
to
275bf2d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Another step forward!
TypeMeta: metav1.TypeMeta{ | ||
APIVersion: "v1", | ||
Kind: "Secret", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In order to avoid harcoding these literals, I opted for adding the corev1 k8s API as a dependency and just did:
TypeMeta: metav1.TypeMeta{
Kind: k8scorev1.ResourceSecrets.String(),
APIVersion: k8scorev1.SchemeGroupVersion.WithResource(k8scorev1.ResourceSecrets.String()).String(),
},
...
See what you think, but anyway, I'll try to be as consistent as possible to avoid future issues when upgrading k8s versions.
I mean, I'm happy to change the kapp-related code I wrote to use the literals directly if you think otherwise, but, you know, we better keep it uniform.
Note: this comment also applies to the CreateNamespace
function, but it was already merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good, I'll update to that.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
plugin. Signed-off-by: Michael Nelson <minelson@vmware.com>
Signed-off-by: Michael Nelson <minelson@vmware.com>
Signed-off-by: Michael Nelson <minelson@vmware.com>
Signed-off-by: Michael Nelson <minelson@vmware.com>
Signed-off-by: Michael Nelson <minelson@vmware.com>
275bf2d
to
6866aea
Compare
Description of the change
Following on from #3914, this PR adds the implementations for
CreateSecret
andGetSecretNames
.Benefits
Can now update the dashboard to use the new endpoints rather than hitting the k8s API server.
Possible drawbacks
Applicable issues
Additional information