App repository update form fix for filters (#3447) #3931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
antgamdia
approved these changes
Dec 13, 2021
| @@ -59,7 +59,7 @@ export class AppRepository { | |||
| ociRepositories, | |||
| tlsInsecureSkipVerify: skipTLS, | |||
| passCredentials: passCredentials, | |||
| filter, | |||
| filterRule: filter, | |||
There was a problem hiding this comment.
I wish every bug was that simple to solve :P
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Rafa Castelblanque rcastelblanq@vmware.com
Description of the change
This PR fixes a problem with updating an app repository with filters.
Repo filter data is now processed correctly both in backend and frontend.
Benefits
App repository filters are no longer gone after repo data update.
Possible drawbacks
N/A
Applicable issues
Additional information
I have added a test file for
AppRepositorygiven that none was existing.