Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync chart with bitnami/kubeapps chart (version 7.6.3) #3954

Merged
merged 3 commits into from
Dec 14, 2021

Conversation

kubeapps-bot
Copy link
Collaborator

Description of the change

This is an automatic PR for synchronizing the changes performed externally at the bitnami/kubeapps official chart to the Kubeapps development version.

Benefits

The Kubeapps development chart will get the newest changes, including image version updates and other updates.

Possible drawbacks

Although unlikely, some changes implemented by the Bitnami team may not be 100% compatible with the current Kubeapps version.

Applicable issues

N/A

Additional information

This PR is marked as a draft until a Kubeapps maintainer manually reviews it.

kubeapps-bot and others added 3 commits December 14, 2021 23:52
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Copy link
Contributor

@antgamdia antgamdia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber-stamping as it is just a change in the chart version

@antgamdia antgamdia marked this pull request as ready for review December 14, 2021 23:58
@antgamdia antgamdia merged commit 36e71b1 into master Dec 14, 2021
@antgamdia antgamdia deleted the sync-chart-changes-7.6.3 branch December 14, 2021 23:58
@castelblanque
Copy link
Collaborator

Shouldn't we update release notes of v2.4.2 to point to chart 7.6.2 instead of 7.6.1?
If I get it right, currently Bitnami chart is on v7.6.2 pointing to Kubeapps v2.4.2? e.g. here

@antgamdia
Copy link
Contributor

AFAIK, it is since v7.6.1 that the Bitnami chart starts packaging the Kubeapps v2.4.2 version, hence we set this value in the release notes. The latest past version just includes some minor changes on the values.yaml file to fix some issues (well, in fact, they caused others) with the readme generator project.
In short, we show there the first chart version with the released version, but I'm ok with changing it to sth like "starting from v7.6.1" or similar to make it clearer.

@castelblanque
Copy link
Collaborator

No problem, just asked due to the fact that there was this "bugfix" on the chart ({} instead of "" ?) and I assumed that v7.6.1 was wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants