Fix for malformed can-i URL (#2719) #3960
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Rafa Castelblanque rcastelblanq@vmware.com
Description of the change
This PR prevents FE from placing can-i requests with malformed URLs that otherwise end up in 404 or 405 HTTP errors.
Thought that it was more correct formally not placing the requests instead of returning
200 OK
with bodyauthorized: no
. Reason being that the URL was incorrect, and not the parameters.Benefits
Less useless requests from browser to backend for can-i checks.
Possible drawbacks
N/A
Applicable issues
Additional information