Fix repeated operator resources shown in dashboard (#3574) #3968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
antgamdia
approved these changes
Dec 16, 2021
There was a problem hiding this comment.
Great! Thanks, also, for the explanation in #3574 (comment)
| @@ -321,7 +321,7 @@ export function getResources( | |||
| try { | |||
| const csvResources = await Operators.listResources( | |||
| cluster, | |||
| namespace, | |||
| csv.metadata.namespace, | |||
There was a problem hiding this comment.
So this is why the namespace wasn't being set? Interesting
There was a problem hiding this comment.
Exactly, when having selected "all namespaces" in the switch button, namespace value would be "".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Rafa Castelblanque rcastelblanq@vmware.com
Description of the change
Fix for operators resources showing repeated times (as many as namespaces existing in cluster) when listing installed items with "Show apps in all namespaces" marked in Dashboard.
Also added the label with namespace to cards.
Issue affects only the Dashboard/FE.
Benefits
Realistic view of what operators resources are installed on each namespace.
Possible drawbacks
N/A
Applicable issues
Additional information