Added some more cases to the tests for chars encoding (#3758) #3998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Rafa Castelblanque rcastelblanq@vmware.com
Description of the change
Extension of tests introduced in #3758 to cover characters other than space in chart names, although Helm specifies that
chart names must contain only lower case letters and numbers. Words may be separated with dashes (-). See Helm general conventions.Therefore, the special characters tested in this PR won't have effect for Helm, as it will fail if chart contains them. Maybe for systems other than Helm is useful.
Benefits
Bit more test coverage for special characters encoding on chart names
Possible drawbacks
N/A
Applicable issues
Additional information
Maybe we should limit the possible characters available for package names.