Add GetAppRepository to kubeops backend #4027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Nelson <minelson@vmware.com>
Signed-off-by: Michael Nelson <minelson@vmware.com>
antgamdia
approved these changes
Jan 5, 2022
| @@ -60,13 +61,13 @@ func JSONError(w http.ResponseWriter, err interface{}, code int) { | |||
| json.NewEncoder(w).Encode(err) | |||
| } | |||
|
|
|||
| func returnK8sError(err error, w http.ResponseWriter) { | |||
| func returnK8sError(err error, action string, resource string, w http.ResponseWriter) { | |||
There was a problem hiding this comment.
Great, more meaningful error messages
| } | ||
| } | ||
| } | ||
|
|
||
| // GetAppRepository gets an App Repository with a related secret if present. | ||
| func GetAppRepository(kubeHandler kube.AuthHandler) func(w http.ResponseWriter, req *http.Request) { |
There was a problem hiding this comment.
I guess this function will get eventually moved to the new repositories API
There was a problem hiding this comment.
Yep, indeed, but that needs to be properly designed for a more generic approach etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This PR primarily adds an endpoint to the current kubeops backend handler to get an app repository, importantly, that includes the related auth header/ca.crt secret in the response. The dashboard currently relies on fetching app repo secrets directly from the k8s API server, which we want to remove. This is an initial work-around to avoid requiring a generic get secret endpoint (see #3922 for discussion of options).
While there, I've fixed the
returnK8sErrorhelper which was logging incorrect and hence confusing information.Benefits
It'll enable the followup PR which updates the dashboard to no longer fetch secrets via the k8s API.
Possible drawbacks
Applicable issues
Additional information