No more secret requests to K8s API #4034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Nelson <minelson@vmware.com>
Signed-off-by: Michael Nelson <minelson@vmware.com>
Signed-off-by: Michael Nelson <minelson@vmware.com>
Signed-off-by: Michael Nelson <minelson@vmware.com>
absoludity
commented
Jan 6, 2022
| if (repo?.spec?.dockerRegistrySecrets?.some(s => s === secretName)) { | ||
| setSelectedImagePullSecret(secretName); | ||
| } | ||
| }); | ||
| }, [imagePullSecrets, repo, selectedImagePullSecret]); | ||
| }, [imagePullSecrets, repo]); |
There was a problem hiding this comment.
I removed selectedImagePullSecret from the dependencies here, as it was causing a bug: every time you selected a different image pull secret, it would trigger this effect, which would set the selected image pull secret back to the one that matches the repos current reference, effectively stopping you from ever changing it.
antgamdia
approved these changes
Jan 6, 2022
| }); | ||
|
|
||
| const secretNames = []; | ||
| for (const [name, type] of Object.entries(result.secretNames)) { |
There was a problem hiding this comment.
Perhaps less wordy with a for..in statement but fine either way
Comment on lines
-370
to
-371
| // TODO(andresmgot): Create an endpoint for returning just the list of secret names | ||
| // to avoid listing all the secrets with protected information |
There was a problem hiding this comment.
We are finally doing it :P
There was a problem hiding this comment.
Yeah, I was sad I couldn't close the related issue (because it was already closed, not sure why).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This PR follows on from #4028, updating the AppRepoForm so that it fetches the image pull secret names only (from the resources API), rather than fetching (and storing in global state) the image pull secrets for a namespace. Also updated, while there, to no longer use global state for these, but rather just local state on the form.
It also does some cleaning up, so that
shared/Secret.tsno longer has any references to the k8s API, as well as removing the urls fromshared/urlsetc.Tested IRL.
Benefits
Kubeapps no longer hits the k8s API for secrets, nor does it expose any method for fetching secrets generally.
Possible drawbacks
Applicable issues
Additional information