Add detailed status msgs for installed carvel pkgs #4059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
21 tasks
absoludity
approved these changes
Jan 11, 2022
| installedPackageDetail.Status = &corev1.InstalledPackageStatus{ | ||
| Ready: pkgInstall.Status.Conditions[0].Type == kappctrlv1alpha1.ReconcileSucceeded, | ||
| Reason: statusReasonForKappStatus(pkgInstall.Status.Conditions[0].Type), | ||
| UserReason: userReasonForKappStatus(pkgInstall.Status.Conditions[0].Type), | ||
| UserReason: pkgInstall.Status.UsefulErrorMessage, // long message, instead of the simpleUserReasonForKappStatus |
There was a problem hiding this comment.
Nice to have an explicit useful error message :P
antgamdia
changed the base branch from
master
to
3680-repos-read-role-aggregation
antgamdia
changed the base branch from
3680-repos-read-role-aggregation
to
master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Due to the wide variety of reasons why a carvel package can fail we initially opted for summarizing the this reason "deployed/ reconcilling/...". However this info is not enough when viewing a given installed package, where we would expect to see more details about the failure.
Benefits
More detailed info in the installed carvel pkg view
Possible drawbacks
N/A
Applicable issues
Additional information