Update check in e2e test to use resources api. #4065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Nelson <minelson@vmware.com>
Signed-off-by: Michael Nelson <minelson@vmware.com>
|
Nice to see that there was only a single point in CI tests (apart from operators maybe?) where K8s API was hit! |
|
Looking forward to getting rid of generated files. I believe it would remove noise in the dev process 😄 |
castelblanque
approved these changes
Jan 12, 2022
Signed-off-by: Michael Nelson <minelson@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Michael Nelson minelson@vmware.com
Description of the change
This is a prequel PR to fix the issue blocking CI in #4054.
Specifically, it updates the 02-create-private-registry test so that it no longer tries to hit the k8s API to verify that the created secret was used with the deployment.
Instead, it uses the resources API to fetch the same deployment data.
There was a bit of a yack-shave, in that it turned out that I was incorrectly using an
Anyproto field for theGetInstalledPackageResourceRefsResponse, which meant that the http/gateway endpoint didn't work for this URL (complaining that the Any field didn't have a TypeURL). An Any field should only ever be used for any message, not any data. So instead, the manifest field is now more correctly a string field. This required a small update to the dashboard also.Benefits
#4054 can land, which will complete #3896
Possible drawbacks
Applicable issues
Additional information