-
Notifications
You must be signed in to change notification settings - Fork 702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Terminology changes: replacing controversial terms from our codebase #4101
Conversation
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Personally, I have no problem with long PRs for automated or manual mechanical changes. They don't require thought. If it's not automated, but is a boring mechanical change, it just requires scanning usually. Not hard to keep context for thousands of lines :)
Right, so it's not automated, but manual mechanical changes.
+1 to add the linters as part of CI, assuming false positives can be noted for ignoring by the linter?
|
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> Conflicts: go.sum
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
It is something I'd like to work on when defining the new Kubeapps website. In fact, the linters I mentioned are from my local branch where I performed some changes for the new webpage. After the +1 from Pepe, I'm renaming |
Description of the change
This (long, sorry!) PR is performing minor renames in some of the terminology used across the project.
Some automatic linters have been used to detect the issues, but in most cases, the replacement is manual (ie. please expect some unnoticed remaining items).
Perhaps we might want to add those linters as part of our Ci process; perhaps not as a blocker step (due to the false positives), but as a report we can check from time to time.
In case anyone is interested they are:
inclusivity
(from here),Joblint
,proselint
,write-good
Benefits
We'll be one step ahead in the conformance with OSS good practices.
Possible drawbacks
N/A
Applicable issues
Additional information
DO NOT MERGE
until the
master
branch has been renamed tomain
, otherwise the CI will fail.