Use react-router-dom when possible #4137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Merged
|
Excellent, an easy but effective fix. Thanks! |
castelblanque
approved these changes
Jan 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
When upgrading some deps at #4121, I noticed there were a few errors related to react-router.
This PR is replacing some imports from
react-routerto the library we extensively use across the projectreact-router-dom. Whereas they are both really similar, the latter includes some defaults values for web applications (instead of being generic so that react-native applications can also use the routing features).Benefits
This change makes the tests pass after bump up the versions in #4121.
Possible drawbacks
N/A
Applicable issues
N/A
Additional information
Unfortunately, I don't know what is the root cause. Nevertheless, we are using an old version of react-router. In v6 there are plenty of breaking changes. However, the required effort isn't worthwhile atm (and they are still developing some adapters to ease the transitions, so we better keep waiting).