Bump helm.sh/helm/v3 from 3.7.2 to 3.8.0 #4154
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps [helm.sh/helm/v3](https://github.com/helm/helm) from 3.7.2 to 3.8.0. - [Release notes](https://github.com/helm/helm/releases) - [Commits](helm/helm@v3.7.2...v3.8.0) --- updated-dependencies: - dependency-name: helm.sh/helm/v3 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
added
dependencies
|
I've been having a look at the changes in this version. The most important one is that they move the OCI support out of the However, in this movement, they have implemented limited 3rd party devs interface. For example: configuring an OCI registry client: credentialsFile string
out io.Writer
authorizer auth.Client
registryAuthorizer *registryauth.Client
resolver remotes.ResolverSource: https://github.com/helm/helm/blob/main/pkg/registry/client.go#L160 those fields are unexported, meaning you have to use the NewClient functions. However, you are limited to the At this point, I can think of different alternatives:
My 2cents... given the current bandwidth and current prioritization of OCI things I'd rather go with Edit: I've performed the required changes for the 2.ii option, mainly adapting the |
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> Conflicts: go.mod go.sum
| helm.sh/helm/v3 v3.8.0 | ||
| k8s.io/api v0.23.1 | ||
| k8s.io/apiextensions-apiserver v0.23.1 | ||
| k8s.io/apimachinery v0.23.1 | ||
| k8s.io/cli-runtime v0.23.1 | ||
| k8s.io/client-go v0.23.1 |
There was a problem hiding this comment.
The command go mod tidy insists on updating these deps to this version (which is the one Helm uses). However, it does not really affect us since we are overriding the actual version in the replace section.
Given our code is ready to use post-k8s-1.21 deprecations, I'd bet it's safe to update to 1.23 as soon as it becomes available in GKE.
+1 for something in between |
| if !ok { | ||
| return nil, manifest.Digest.String(), errors.Errorf("Unable to retrieve blob with digest %s", chartDescriptor.Digest) | ||
| } | ||
|
|
||
| return bytes.NewBuffer(chartData), manifest.Digest.String(), nil | ||
| } | ||
|
|
||
| // Code from Helm Registry Client. Copied here since it belonged to a internal package. |
There was a problem hiding this comment.
Here would be an ideal spot to reference an upstream issue discussing this.
There was a problem hiding this comment.
t'd be worth creating an issue to begin the conversation upstream and see whether it's something they're keen to do or at least see done.
Done: helm/helm#10623
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> Conflicts: go.sum
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> Conflicts: go.sum
Bumps helm.sh/helm/v3 from 3.7.2 to 3.8.0.
Release notes
Sourced from helm.sh/helm/v3's releases.
... (truncated)
Commits
d141386Limits need to call tag API when explicit version specifiedd493f29bump version to v3.8.0c137bfbMerge pull request #10546 from dperaza4dustbit/move_oci_out_experimental9661e39Moving uploader and pusher out of action into pkg7cab1a0Move all the remainder module out of experimental.9f869c6Removing all the checks for oci experimental flag91a46admove paths for updated directory location353d74erefactor internal/experimental/registry to pkg/registrya27c468Merge pull request #10547 from mattfarina/fix-panic548ec55Fix panic with OCI for install, upgrade, and showDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)