Rename MasterURL to APIServerURL
#4155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
antgamdia
changed the title
MasterURL with APIServerURLMasterURL to APIServerURL
absoludity
approved these changes
Jan 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This PR simply addresses an intentional leftover in #4101 as it is an actual change in the code.
However, as far as I'm concerned, this param is not being used in our chart or ci scripts.
I've used
--apiserveras the param name, but happy to change it to any other better alternative you think of.Benefits
The param name won't point to an outdated name in kubernetes (
masternodes were renamed tocontrol planelong time ago).Possible drawbacks
Unnoticed uses of this param elsewhere?
Applicable issues
Additional information
N/A