Allow changing the k8s target version in Cargo #4166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
antgamdia
commented
Jan 25, 2022
Comment on lines
+47
to
+48
| > **NOTE**: at least one of those `GKE_STABLE_VERSION_XX` or `GKE_REGULAR_VERSION_XX` versions _must_ match the Kubernetes-related dependencies in [Go](../../go.mod) and [Rust](../../cmd/pinniped-proxy/Cargo.toml). | ||
|
|
There was a problem hiding this comment.
We aren't actually following this recommendation indeed (we already had the v1.22 in some places, so as soon as GKE bumps it up as well, we will comply again)
absoludity
approved these changes
Jan 26, 2022
Co-authored-by: Michael Nelson <absoludity@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This trivial PR just extracts the version used in the
k8s-openapidependency apart into a Cargo feature. This way any piece of code depending onpinniped-proxycan modify the target k8s platform simply compiling it with afeature.Defaulting to the same value it has.
Benefits
Pinniped-proxy will be simpler to configure when used as a dependency.
Possible drawbacks
N/A
Applicable issues
N/A
Additional information
I've added also a note in the release docs talking about then kubernetes-related deps.