Add default allow downgrades in carvel pkgs #4192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
This was referenced Jan 31, 2022
absoludity
approved these changes
Jan 31, 2022
There was a problem hiding this comment.
When you first mentioned this option, I'd not realised it would be setting an annotation on the installed packages (thought it would be affecting how we calculate the version selector). Not sure about setting the annotation as a blanket, but assume you've thought through the consequence (and it's a default that we may later enable changing per package etc.)
Co-authored-by: Michael Nelson <absoludity@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This PR simply adds support for another default plugin-wide configuration as I commented at #4165 (comment).
More specifically, it enables users to decide whether or not the packages can be upgraded to a prior version, that is, a downgrade. This is done by adding (or not) an annotation in the
PackageInstallobjects.Benefits
More customization options for Carvel plugin users.
Possible drawbacks
At the moment, this is a plugin-wide configuration, meaning it cannot be modified (yet) for specific packages.
Nevertheless, it is a good way to identify which config options we may want to add in the UI in the future,
Applicable issues
Additional information
N/A