Fix for Cannot view newly created flux 2 package from UX #4173 #4204
Conversation
Cannot view newly created flux 2 package from UX
| // '[TargetNamespace-]Name'. | ||
| if helmReleaseName == "" { | ||
| targetNamespace := rel.Spec.TargetNamespace | ||
| // according to docs targetNamespace is optional and defaults to the namespace of the HelmRelease |
There was a problem hiding this comment.
Just noting, not necessary for this fix, but for the related #4189, that the behaviour flux shows is slightly different to below (see my notes from updating the flux CR on #4172, or your notes on #4189) but still consistent with the comment above: the namespace targeted by the HelmRelease defaults to the namespace of the HelmRelease, but flux doesn't set the targetNamespace field with that value, it remains empty as specified. And when the targetNamespace is empty/unset, the helm release name is just the HelmRelease.metadata.name (ie. not prefixed by the namespace at all, and so different to below). This is why I was unsure why we were explicitly setting the targetNamespace given flux's default behaviour.
There was a problem hiding this comment.
Just noting, not necessary for this fix, but for the related #4189, that the behaviour flux shows is slightly different to below (see my notes from updating the flux CR on #4172, or your notes on #4189) but still consistent with the comment above: the namespace targeted by the
HelmReleasedefaults to the namespace of theHelmRelease, but flux doesn't set thetargetNamespacefield with that value, it remains empty as specified. And when thetargetNamespaceis empty/unset, the helm release name is just theHelmRelease.metadata.name(ie. not prefixed by the namespace at all, and so different to below). This is why I was unsure why we were explicitly setting thetargetNamespacegiven flux's default behaviour.
noted
| if targetNamespace == "" { | ||
| targetNamespace = key.Namespace | ||
| } | ||
| helmReleaseName = fmt.Sprintf("%s-%s", targetNamespace, key.Name) |
There was a problem hiding this comment.
Just leaving this here so I can refer to it on your related issue #4189, not suggesting the change for this PR
| if targetNamespace == "" { | |
| targetNamespace = key.Namespace | |
| } | |
| helmReleaseName = fmt.Sprintf("%s-%s", targetNamespace, key.Name) | |
| helmReleaseName = key.Name | |
| if targetNamespace != "" { | |
| helmReleaseName = fmt.Sprintf("%s-%s", targetNamespace, key.Name) | |
| } |
which would match the behaviour that I saw by default from flux, I think.
There was a problem hiding this comment.
ok, sounds good
No description provided.