Call GetInstalledPackageResourceRefs with exp backoff. #4233
Conversation
| // with 500ms, 1000ms, 2000ms, 4000ms etc. | ||
| const wait = (ms: number) => new Promise(res => setTimeout(res, ms)); | ||
|
|
||
| const callWithRetry = async (fn: any, initialWait: number, depth = 0): Promise<any> => { |
There was a problem hiding this comment.
What if we just use a library instead for also adding jitter to this exp backoff, like https://github.com/lifeomic/attempt ?
There was a problem hiding this comment.
@antgamdia thanks for the article about jitter, superinteresting!
That library looks easy to implement 😄
There was a problem hiding this comment.
Why would we need jitter here? It's guaranteed to be a single client fetching the resource refs after creating the package... unless we coordinate a DDOS on a Kubeapps installation :P. (ie. we don't have the situation described in the article that leads to adding jitter to an exponential backoff, nor could we, unless I'm missing something?)
|
By the way, do you think we should add some kind of spinner when waiting?
If so, (probably in another PR) we should let the |
absoludity
force-pushed
the
3695-check-installed-pkg-details-6
branch
from
e1a35df
to
5b35ec8
Compare
absoludity
force-pushed
the
3695-check-installed-pkg-details-5
branch
from
d7437d4
to
660e74e
Compare
Signed-off-by: Michael Nelson <minelson@vmware.com>
absoludity
force-pushed
the
3695-check-installed-pkg-details-6
branch
from
5b35ec8
to
8f07b43
Compare
Signed-off-by: Michael Nelson minelson@vmware.com
Description of the change
See #4213 for description of the problem.
This change just ensures that the call will retry a number of times, backing off exponentially. For Flux it only needs to be a second, but carvel has other needs.
Benefits
Error no longer shown when first deploying flux package.
Possible drawbacks
Applicable issues
Additional information