Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preparation for release v2.4.3 #4234

Merged
merged 7 commits into from
Feb 9, 2022
Merged

Preparation for release v2.4.3 #4234

merged 7 commits into from
Feb 9, 2022

Conversation

castelblanque
Copy link
Collaborator

Description of the change

This PR adds:

  • Dependency updates for source code
  • Updates from Bitnami chart (mainly a change in the ingress certManagerRequest)

Benefits

We can have prepared release v2.4.3

Possible drawbacks

E2E tests 03 and 07 seem to be failing consistently now. I'm preparing another PR that should fix that.

Rafa Castelblanque added 2 commits February 4, 2022 13:58
Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
@@ -33,4 +33,4 @@ maintainers:
name: kubeapps
sources:
- https://github.com/kubeapps/kubeapps
version: 7.8.0-dev3
version: 7.7.4
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@antgamdia Is this version correct?
Bitnami chart version

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, I don't think so. Since we added new params in the chart (in the kapp-ctrl plugin config), this should be a minor release according to the Content team. So I just bumped it to 7.8.0 in the first change, and then I continue modifying the devXX prerelease tag.
In short, I don't think we should modify the chart version here.

What we do have to change, though, is this version once our CI creates the PR in the bitnami/charts repo. I mean, in their repo, not in ours.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, got it! Thanks

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@@ -33,4 +33,4 @@ maintainers:
name: kubeapps
sources:
- https://github.com/kubeapps/kubeapps
version: 7.8.0-dev3
version: 7.7.4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, I don't think so. Since we added new params in the chart (in the kapp-ctrl plugin config), this should be a minor release according to the Content team. So I just bumped it to 7.8.0 in the first change, and then I continue modifying the devXX prerelease tag.
In short, I don't think we should modify the chart version here.

What we do have to change, though, is this version once our CI creates the PR in the bitnami/charts repo. I mean, in their repo, not in ours.

@@ -26,6 +26,7 @@
"watch-css": "yarn run build-css && yarn run compile-lang && sass src/ --watch --no-source-map"
},
"dependencies": {
"@babel/parser": "^7.15.3",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this one is required. Sometimes it becomes added when doing yarn upgrade, but it is already present as part of the react-scripts deps. If you remove it and then run yarn install, you'll notice everything works fine.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

Rafa Castelblanque added 5 commits February 4, 2022 16:37
Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
@castelblanque castelblanque marked this pull request as ready for review February 9, 2022 12:22
Copy link
Contributor

@antgamdia antgamdia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks for the upgrades :)

@castelblanque castelblanque merged commit 6793690 into main Feb 9, 2022
@castelblanque castelblanque deleted the prerelease-v2.4.3 branch February 9, 2022 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants