-
Notifications
You must be signed in to change notification settings - Fork 702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preparation for release v2.4.3 #4234
Conversation
Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
chart/kubeapps/Chart.yaml
Outdated
@@ -33,4 +33,4 @@ maintainers: | |||
name: kubeapps | |||
sources: | |||
- https://github.com/kubeapps/kubeapps | |||
version: 7.8.0-dev3 | |||
version: 7.7.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@antgamdia Is this version correct?
Bitnami chart version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, I don't think so. Since we added new params in the chart (in the kapp-ctrl plugin config), this should be a minor
release according to the Content team. So I just bumped it to 7.8.0 in the first change, and then I continue modifying the devXX prerelease tag.
In short, I don't think we should modify the chart version here.
What we do have to change, though, is this version once our CI creates the PR in the bitnami/charts repo. I mean, in their repo, not in ours.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, got it! Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
chart/kubeapps/Chart.yaml
Outdated
@@ -33,4 +33,4 @@ maintainers: | |||
name: kubeapps | |||
sources: | |||
- https://github.com/kubeapps/kubeapps | |||
version: 7.8.0-dev3 | |||
version: 7.7.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, I don't think so. Since we added new params in the chart (in the kapp-ctrl plugin config), this should be a minor
release according to the Content team. So I just bumped it to 7.8.0 in the first change, and then I continue modifying the devXX prerelease tag.
In short, I don't think we should modify the chart version here.
What we do have to change, though, is this version once our CI creates the PR in the bitnami/charts repo. I mean, in their repo, not in ours.
dashboard/package.json
Outdated
@@ -26,6 +26,7 @@ | |||
"watch-css": "yarn run build-css && yarn run compile-lang && sass src/ --watch --no-source-map" | |||
}, | |||
"dependencies": { | |||
"@babel/parser": "^7.15.3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this one is required. Sometimes it becomes added when doing yarn upgrade
, but it is already present as part of the react-scripts deps. If you remove it and then run yarn install, you'll notice everything works fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Thanks for the upgrades :)
Description of the change
This PR adds:
Benefits
We can have prepared release v2.4.3
Possible drawbacks
E2E tests 03 and 07 seem to be failing consistently now. I'm preparing another PR that should fix that.