Enable showing the progression of a pending installation. #4247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -134,10 +134,15 @@ export default function ApplicationStatus({ | |||
| </div> | |||
| ); | |||
| } | |||
| if (info && info.status) { | |||
| if (info?.status?.reason) { | |||
| // If the status code is different than "Deployed", display that status | |||
There was a problem hiding this comment.
Shouldn't we update this comment to include the pending status added, or it is not related to the if condition modified?
There was a problem hiding this comment.
Woops, yep, I'll update it. Thanks.
|
Great to have better UI feedback, thanks! |
castelblanque
approved these changes
Feb 8, 2022
absoludity
force-pushed
the
3695-check-installed-pkg-details-6
branch
2 times, most recently
from
5b35ec8
to
8f07b43
Compare
Signed-off-by: Michael Nelson <minelson@vmware.com>
Signed-off-by: Michael Nelson <minelson@vmware.com>
absoludity
force-pushed
the
3695-check-installed-pkg-details-7
branch
from
b4db2be
to
9835815
Compare
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Currently, when a flux2 package is installed, the installed package is created but remains in the pending state until the reconciliation completes. As it was, the ApplicationStatus component did not display the pie chart while the app was in the pending state and the app.status never updates in the UX, yet we have all the data required to display the pie chart at this point (ie. we can fetch the resources already etc.)
There is a second issue which I'll deal with in a fdlow-up PR, in that the app status never updates in the view. It seems we stream the resources and so get all the updates there, but for the straight helm case, there was never a need to re-fetch the app (the helm release). The only effect of this in the UX currently is that for this flux case, where a newly installed package is initially in the pending status, the buttons (upgrade/delete) never re-enable.
Benefits
When installing a package with flux, we now see the pie chart as soon as the resources have been fetched and can see it progress to completion.
Possible drawbacks
I need to check whether we use this pending state for the straight helm case. From memory we may see it in the UX when there are pre-install hooks, although, if that's the case, I'd expect you'd need to refresh the page (due to the issue above of the app status not updating in the UX). Even if so, I then suspect we'd simply display "No resources found" until the state changed in helm itself and the resources were created. Hopefully CI will show whether it still works.
Applicable issues
Additional information