Ensure only one of helm or fluxv2 plugins are configured. #4257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Nelson <minelson@vmware.com>
absoludity
commented
Feb 10, 2022
| @@ -1,12 +1,12 @@ | |||
| dependencies: | |||
| - name: common | |||
| repository: https://charts.bitnami.com/bitnami | |||
| version: 1.11.0 | |||
| version: 1.11.1 | |||
There was a problem hiding this comment.
I was getting the following error until I updated the deps:
Error: UPGRADE FAILED: template: kubeapps/templates/ingress.yaml:54:42: executing "kubeapps/templates/ingress.yaml" at <include "common.ingress.certManagerRequest" (dict "annotations" .Values.ingress.annotations)>: error calling include: template: no template "common.ingress.certManagerRequest" associated with template "gotpl"
antgamdia
approved these changes
Feb 10, 2022
|
Great, thanks for the improvement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Michael Nelson minelson@vmware.com
Description of the change
Currently it's possible to configure the kubeapps apis service with both the fluxv2 and helm plugins running. This is not something we are able to support right now, since it would enable interacting with the helm releases directly when they are being managed by flux (as well as confusingly display apps twice).
I've used the new chart validation that @antgamdia added recently, since it's nice to catch the configuration issue before doing the deployment.
Benefits
We don't allow a configuration which we don't intend to support.
Possible drawbacks
Applicable issues
Additional information
Next up, removing the need to enable redis (and removing postgres when helm plugin is not used? - possibly, depends on effects, may need to also remove assetsvc, apprepo controller etc.).