Fix for test 01 aimed at GKE #4258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
antgamdia
approved these changes
Feb 10, 2022
antgamdia
reviewed
Feb 10, 2022
| @@ -28,6 +28,8 @@ test.describe("Limited user simple deployments", () => { | |||
| await releaseNameLocator.fill(utils.getRandomName("test-01-release")); | |||
| await page.locator('cds-button:has-text("Deploy")').click(); | |||
|
|
|||
| // Assertions | |||
| await page.waitForSelector(".alert-items .alert-text"); | |||
There was a problem hiding this comment.
So it was just a kind of race condition, that's why retrying made it to work?
There was a problem hiding this comment.
Yeah, I would say that if the error message was appearing almost immediately, the problem was hidden. It makes total sense to have this waitForSelector, as neither page.locator nor expect(errorLocator) wait for the error to be there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Rafa Castelblanque rcastelblanq@vmware.com
Description of the change
Fixes the E2E test number 01 that is failing in GKE but not on Kind.
Benefits
Test should not fail now in GKE.
Possible drawbacks
Hopefully none