Avoid CRD deletion when upgrading

[andresmgot]

Fixes #800

[arapulido]

What versions of the chart are affected by this issue?

[andresmgot]

The code related to the CRD was changed in the version 0.3.0 but I doubt this is an issue since then (Aug 23). We would have noticed before. Let's see if @migmartri or @prydonius know something else about this issue.

[migmartri]

Thank you @andresmgot for noticing the issue and fixing it.

The code related to the CRD was changed in the version 0.3.0 but I doubt this is an issue since then (Aug 23). We would have noticed before.

I am afraid that the issue might have been actually there and this is the reason I have not noticed it #800 (comment)

There is a report of a potential instance of the error here #625 and I saw it once but could not reproduce.

[migmartri]

I guess that the only gotcha of this solution is that in theory we are re-attaching the existing CRDs to the latest kubeapps instance that was upgraded. Which in practice I don't see any issue with since we use the keep annotation.

[prydonius]

@migmartri yes, I think this could potentially be an issue if we update the AppRepository CRD in a new release, and there are other instances of Kubeapps relying on the CRD. Speaking of, created #803 to address bumping the AppRepo CRD version.

[andresmgot]

I understand the issue. In any case, CRDs are cluster wide so in any case, several instances of Kubeapps needs to be upgraded if we change the version of the CRD. I am landing this PR to fix the original issue. Thanks for the input!