Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement dashboard changes to add a customCA to a repository #894

Merged
merged 4 commits into from Dec 20, 2018

Conversation

andresmgot
Copy link
Contributor

Closes: #515
Continuation of #878

Frontend changes to support custom CA certificates:

screenshot 2018-12-19 at 17 11 46

screenshot 2018-12-19 at 17 10 48

Copy link
Contributor

@migmartri migmartri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

dashboard/src/actions/repos.ts Outdated Show resolved Hide resolved
dashboard/src/actions/repos.ts Show resolved Hide resolved

.CertContent {
// Copied from <code> style
font-family: "SFMono-Regular", Consolas, Liberation Mono, Menlo, Courier, monospace;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not have any existing class in hex that could help us with that?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the hex style for this is to wrap code around a block <pre><code>.... The problem here is that textarea has its own style that takes precedence and the combination doesn't look good. That's why I need this.

Copy link
Contributor

@prydonius prydonius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, lgtm!

dashboard/src/actions/repos.ts Show resolved Hide resolved
@andresmgot andresmgot merged commit fa96732 into vmware-tanzu:master Dec 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants