Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor AppView Secret rendering #942

Merged
merged 4 commits into from Jan 30, 2019
Merged

refactor AppView Secret rendering #942

merged 4 commits into from Jan 30, 2019

Conversation

prydonius
Copy link
Contributor

@prydonius prydonius commented Jan 26, 2019 •
edited

  • refactors SecretsTable, SecretItem to make use of the new ResourceRefs
  • SecretsTableContainer is removed and SecretItemContainer is linked to
    the Redux store
  • SecretItem now handles fetching of the Secret resource
  • SecretItemDatum is added to handle the presentational concerns of a
    single key/value pair in a Secret, avoiding the need for complicated
    state management in SecretItem

refs #882

screen shot 2019-01-25 at 15 50 15

prydonius
prydonius commented Jan 26, 2019
View reviewed changes
dashboard/src/containers/SecretItemContainer/SecretItemContainer.ts Outdated
dispatch(
actions.kube.getResource(
secretRef.apiVersion,
"secrets",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will need to change this once #941 lands

andresmgot
andresmgot approved these changes Jan 28, 2019
View reviewed changes
Copy link
Contributor

@andresmgot andresmgot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment. Thanks!

dashboard/src/components/AppView/SecretsTable/SecretItem.tsx Outdated Show resolved Hide resolved
@prydonius prydonius force-pushed the 882-migrate-secrets-to-resourceref branch from 7abb6be to 4a43733 Compare January 28, 2019 23:07
@andresmgot
Copy link
Contributor

New commits LGTM as well

@prydonius
Copy link
Contributor Author

apologies for the confusion with the rebase!

@prydonius prydonius merged commit f7dfa9c into vmware-tanzu:master Jan 30, 2019
@prydonius prydonius deleted the 882-migrate-secrets-to-resourceref branch January 30, 2019 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andresmgot andresmgot andresmgot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@prydonius @andresmgot