Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add verbose flag for karmor probe #227

Closed
wants to merge 3 commits into from
Closed

add verbose flag for karmor probe #227

wants to merge 3 commits into from

Conversation

kranurag7
Copy link
Member

@kranurag7 kranurag7 commented Jan 1, 2023 •
edited

Signed-off-by: Anurag contact.anurag7@gmail.com

Fixes #226

  • Refactored the output of karmor probe.
  • The usual loading time is 1/3rd of the existing one.
  • I tested this on a 3 node GKE cluster and results are following.
# truncated
$ time ./kubearmor-client probe 
./kubearmor-client probe  0.09s user 0.01s system 1% cpu 6.258 total
$ time ./kubearmor-client probe -v 
./kubearmor-client probe -v  0.16s user 0.05s system 1% cpu 18.309 total
  • The new output looks something like this.
$ ./kubearmor-client probe

Found KubeArmor running in Kubernetes

Daemonset :
 	kubearmor 	Desired: 3	Ready: 3	Available: 3	
Armored Up pods :
+-----------+------+--------+
| NAMESPACE | NAME | POLICY |
+-----------+------+--------+
| default   | pod  |        |
+-----------+------+--------+

@kranurag7
add verbose flag for karmor probe
b57a22f 
Signed-off-by: Anurag <contact.anurag7@gmail.com>
nyrahul
nyrahul requested changes Jan 7, 2023
View reviewed changes
probe/probe.go Outdated Show resolved Hide resolved
cmd/probe.go Outdated Show resolved Hide resolved
@yasin-cs-ko-ak
Copy link
Contributor

@kranurag7 Kindly review the suggested changes.
cc: @nyrahul

kranurag7 and others added 2 commits January 28, 2023 20:54
@kranurag7 @nyrahul
Update probe/probe.go
4a93845 
Co-authored-by: Rahul Jadhav <nyrahul@gmail.com>
@kranurag7 @nyrahul
Update cmd/probe.go
3401175 
Co-authored-by: Rahul Jadhav <nyrahul@gmail.com>
@kranurag7
Copy link
Member Author

This proposal is not planned as of now (as per our discussion in community meetings). Closing this. karmor probe does the job.

@kranurag7 kranurag7 closed this Oct 18, 2023
@kranurag7 kranurag7 deleted the probe branch October 18, 2023 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nyrahul nyrahul nyrahul requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Request for new flag while karmor probe
3 participants
@kranurag7 @yasin-cs-ko-ak @nyrahul