Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

karmor uninstall should remove annotations/policies by default #434

Open
DelusionalOptimist opened this issue May 20, 2024 · 1 comment · May be fixed by #440
Open

karmor uninstall should remove annotations/policies by default #434

DelusionalOptimist opened this issue May 20, 2024 · 1 comment · May be fixed by #440
Labels
enhancement New feature or request

Comments

@DelusionalOptimist
Copy link
Member

Description

Currently when users remove KubeArmor with karmor uninstall, by default there pods are left with AppArmor annotations.
This is not desired as it may cause issues in certain cases like:

  • AppArmor policies were deleted manually
  • Enforcer was changed to BPF LSM and apparmor was disabled
    etc.

They have to use --force flag for the same which is also not documented anywhere.

Improvement

Remove annotations and policies/CR(D)s by default.
If user wants to keep it, they use the --keep-policies flag. (Could use suggestions on the flag name)

@rootxrishabh
Copy link
Member

Related - #1589

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

2 participants