Fix bug in both Allocation and Summary Allocation where shared tenanc…

…y cost would slightly skew sharing coefficients for shared resources.
opencost · Mar 17, 2022 · 7ce8347 · 7ce8347
1 parent fd079e1
commit 7ce8347
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/pkg/kubecost/allocation.go b/pkg/kubecost/allocation.go
@@ -1499,8 +1499,8 @@ func computeShareCoeffs(aggregateBy []string, options *AllocationAggregationOpti
 		} else {
 			// Both are additive for weighted distribution, where each
 			// cumulative coefficient will be divided by the total.
-			coeffs[name] += alloc.TotalCost()
-			total += alloc.TotalCost()
+			coeffs[name] += alloc.TotalCost() - alloc.SharedCost
+			total += alloc.TotalCost() - alloc.SharedCost
 		}
 	}
 

diff --git a/pkg/kubecost/summaryallocation.go b/pkg/kubecost/summaryallocation.go
@@ -716,7 +716,7 @@ func (sas *SummaryAllocationSet) AggregateBy(aggregateBy []string, options *Allo
 		// NOTE: SummaryAllocation does not support ShareEven, so only record
 		// by cost for cost-weighted distribution.
 		if sharingCoeffs != nil {
-			sharingCoeffs[key] += sa.TotalCost()
+			sharingCoeffs[key] += sa.TotalCost() - sa.SharedCost
 		}
 
 		// 6. Distribute idle allocations according to the idle coefficients.