Sanitize window duration in ComputeClusterCosts #1074
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
ComputeClusterCosts
, which is a legacy function, but still exposed by two endpoints (i.e. non-ETL aggregated cost model, cluster costs)How does this PR impact users? (This is the kind of thing that goes in release notes!)
Fixes a bug. (See ticket below.)
Links to Issues or ZD tickets this PR addresses or fixes
How was this PR tested?
Before
Worked for any number of minutes that Prometheus can handle, but too small of a window is not going to be accurate at a resolution of 5m:
Fails with Prometheus error for mal-formed window:
After
For windows < 10m (even weird ones) simply stop and return an error:
For windows > 10m with weird formulations, round to a Prometheus-valid window and keep rollin: