Add support for additional AWS pricing regions #1087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome, @kaelanspatel! Is there any reason to determine if there may be others out there not included yet? Don't have to do it as part of this PR but just wanted to ask the question while in here. Also, are we considering this a bug fix we want as part of this release? |
AjayTripathy
approved these changes
Feb 28, 2022
|
Let's patch/cherry pick into the new release candidate.I believe @kaelanspatel did a review of all regions that weren't covered here, but let me know if that's not the case. |
|
I believe the only region not currently included is me-south-1 Bahrain. I think these regions "not being supported" are just an artifact of us not updating the region maps. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
Adds support for the AWS pricing regions eu-south-1 Milan, af-south-1 Cape Town, and ap-southeast-3 Jakarta. Additionally, fixes ap-northeast-3 Osaka not being parsed correctly.
Does this PR rely on any other PRs?
No.
How does this PR impact users? (This is the kind of thing that goes in release notes!)
Add support for AWS regions eu-south-1, af-south-1, and ap-southeast-3.
Fixes an issue with cluster pricing data in AWS region ap-northeast-3.
Links to Issues or ZD tickets this PR addresses or fixes
How was this PR tested?
Tested in ap-northeast-3 and eu-south-1, also verified manually with pricing data download.
Have you made an update to documentation?
No.